commit | 65f0e5da5bc245defe9a4927bc831a41dc6a7c1d | [log] [tgz] |
---|---|---|
author | Sean Gilhuly <sgilhuly@chromium.org> | Fri Jan 04 05:01:20 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 04 05:01:20 2019 |
tree | 1142f5ebea496f81300375ab57154f170011076c | |
parent | eb97d4261c78e63833db9d5fb034919dc256daa3 [diff] |
Call DidNotProduceFrame if begin frames are not needed Begin frames were being processed when there was no BeginFrameObserver, occasionally causing |last_begin_frame_args_| in ExternalBeginFrameSource to be overwritten. These lost frames create a backlog in |pipeline_reporting_frame_times_|, which eventually causes a DCHECK. Remember whether or not begin frames are needed. If they aren't, call DidNotProduceFrame() instead of OnBeginFrame(). This mirrors a check in AsyncLayerTreeFrameSink::OnBeginFrame(). Bug: 916354 Change-Id: Id5361ec6c48044a21c4946585f0da5ef862dd6d5 Reviewed-on: https://chromium-review.googlesource.com/c/1393441 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#619883}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .