commit | 668642c32bf49830c55f4d1e134288cbeb00adb6 | [log] [tgz] |
---|---|---|
author | sangwoo.ko <sangwoo108@chromium.org> | Wed Aug 01 05:27:56 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Aug 01 05:27:56 2018 |
tree | 69338b474ccc0608f861ae27750366e520d6f711 | |
parent | db9054a59d3d843fd5bdb2389845bfb98600070a [diff] |
Introduce TabStripModelObserver::OnTabStripChanged() Previously, selection and content changes were sent as separate callbacks. This caused consistency errors in observers, as the two must be processed simultaneously. TabStripModelObserver::OnTabStripChanged() carries selection and contents data at the same time. And it'll be called after tab strip model finishes it's work. So we don't have to care about model's state that much. Thus, we can replace following with OnTabStripChanged(): void TabInsertedAt(...); void TabReplacedAt(...); void TabMoved(...); void TabClosingAt(...); void TabDetachedAt(...); void TabDeactivated(...); void ActiveTabChanged(...); void TabSelectionChanged(...); Also this callback allows us to handle multiple changes in a single callback. e.g. multiple tab closing, insertion, etc. Change-Id: Iae824f8be536dbe699ba0108bf242114e0906ec7 Bug: 842194 Reviewed-on: https://chromium-review.googlesource.com/1140105 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579707}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .