commit | 66a63dc5a18cb513b856528e3acdcb9e8acff050 | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Wed Nov 14 06:16:20 2018 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Wed Nov 14 06:16:20 2018 |
tree | 20e9b72aa9fc0f1757b24794f65a007b6d428bd3 | |
parent | 78e17bee9c2e5139fb675d08e3527a6e138f3fe4 [diff] |
Revert "Print Preview Refresh: Enable change button while destination loads" This reverts commit 9f695d7249c926ddde8515ce5e7bf8505addecc3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607896 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWY2OTVkNzI0OWM5MjZkZGRlODUxNWNlNWU3YmY4NTA1YWRkZWNjMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/54191 Sample Failed Step: browser_tests Sample Flaky Test: PrintPreviewDestinationSettingsTest.ChangeButtonState Original change's description: > Print Preview Refresh: Enable change button while destination loads > > In some cases (e.g. kiosk apps with no default printer configured), the > print destination may never load. Enable the "Change" button while > destination capabilities are loading so that the user can switch > destinations in this case. > > Bug: 901115 > Change-Id: I53eec9332e0d7f075e461226290d408ae6d6ef49 > Reviewed-on: https://chromium-review.googlesource.com/c/1332703 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607896} Change-Id: I67b37b31938b6af5c19edc09a1e66b9019d0e198 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901115, 905205 Reviewed-on: https://chromium-review.googlesource.com/c/1335278 Cr-Commit-Position: refs/heads/master@{#607919}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .