commit 66c0e97960fed83511d320eded9f028e1cb678ad
author Mandy Chen <mandy.chen@microsoft.com> Mon Apr 22 23:39:44 2019
committer Commit Bot <commit-bot@chromium.org> Mon Apr 22 23:39:44 2019
tree b2e306da73426e37ecced3326da13ab750c75686
parent 67e4dfedd5f8596e06913dbd4f5dc1b67be94ca4

DevTools: Include module.json in build.gn presubmit check


Discovered a bug in check_gn.js, which is part of the presubmit check that
verifies all the devtools frontend files are included in devtools/BUILD.gn.
The bug prevents missing module.json files from being reported.


Output of running npm run check-gn

Before the fix:

DevTools BUILD.gn checker passed

After:

DevTools BUILD.gn checker detected errors!
There's an issue with: D:\chromium\src\third_party\blink\renderer\devtools\BUILD.gn
Missing file in BUILD.gn for all_devtools_files: "front_end\elements_test_runner\module.json",
Missing file in BUILD.gn for all_devtools_files: "front_end\persistence\module.json",
Missing file in BUILD.gn for all_devtools_files: "front_end\search\module.json",
Missing file in BUILD.gn for all_devtools_files: "front_end\services\module.json",
Missing file in BUILD.gn for all_devtools_files: "front_end\terminal\module.json",
Missing file in BUILD.gn for all_devtools_files: "front_end\worker_service\module.json",

I added these missing module.json files to BUILD.gn.

Change-Id: I05a72e353475af142c13f0644fd430361edfff72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576409
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#653018}