commit | 672f4642d63d01fa4ebb32e85365b61287b397f7 | [log] [tgz] |
---|---|---|
author | Nigel Tao <nigeltao@chromium.org> | Thu Jun 20 06:23:22 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 20 06:23:22 2019 |
tree | 74d05e41fff8b95ee82ea29a9411ce20303a8271 | |
parent | a70d015c8236d2b6ae1cd58b0214de2e7627e52b [diff] |
Make App Service conditionally sync app removal When the AppServiceAppModelBuilder removes an ARC++ app, whether or not this is a sync'ed change is now conditional on whether Play Store as a whole was enabled or disabled. This matches the existing behavior (with the App Service disabled), in ArcAppModelBuilder::OnAppRemoved. This commit also changes ChromeLauncherControllerWithArcTest, adding RunUntilIdle calls so that it works with the Mojo IPC based App Service. Together, this fixes `unit_tests --enable-features=AppServiceAsh --gtest_filter="ChromeLauncherControllerWithArcTest.ArcAppPin"`. It fails before and passes after this commit. Note that `unit_tests --gtest_filter="ChromeLauncherControllerWithArcTest.ArcAppPin"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: I418ee223ba40ae0099a173f06d6a06217cbae7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626206 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#670805}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .