commit | 67bf4f720d2826c54fcdba595c20d1b0c1adf60f | [log] [tgz] |
---|---|---|
author | Thiemo Nagel <tnagel@chromium.org> | Tue Jan 08 10:47:00 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 08 10:47:00 2019 |
tree | d0f73cf9e06e6575f45852a086731ee4628bd105 | |
parent | 16a5b10a46d264471b286c211b8a2660bdb9ebc4 [diff] |
Revert "[heap profiler] Make sampling v2 default and remove v1 code." This reverts commit 89fbc0a325f9c4208702a115b723c56efeca6965. Reason for revert: MemlogBrowserTest has started crashing on Mac10.12 This is a speculative revert. (Your CL seems to be the only one on the blamelist that mentions profiling.) I apologize in advance if my suspicion turns out to be unsubstantiated. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/18408 [ RUN ] Memlog/MemlogBrowserTest.EndToEnd/18 [79940:4099:0107/172123.369006:WARNING:notification_platform_bridge_mac.mm(521)] AlertNotificationService: XPC connection invalidated. [79940:775:0107/172123.978820:INFO:memlog_browsertest.cc(87)] Memlog mode: 3 [79940:775:0107/172123.978872:INFO:memlog_browsertest.cc(88)] Memlog stack mode: 0 [79940:775:0107/172123.978889:INFO:memlog_browsertest.cc(89)] Started via command line flag: 0 [79940:775:0107/172123.978911:INFO:memlog_browsertest.cc(91)] Should sample: 1 [79940:775:0107/172123.978924:INFO:memlog_browsertest.cc(92)] Sample everything: 1 [79940:775:0107/172124.276612:WARNING:test_driver.cc(323)] Allocation candidate (size:1241399 count:157) Received signal 11 SEGV_MAPERR 000000000069 Original change's description: > [heap profiler] Make sampling v2 default and remove v1 code. > > BUG=917476 > > Change-Id: I129a9d3af71d239c6be8c117c1c3fbbfe5d86072 > Reviewed-on: https://chromium-review.googlesource.com/c/1391356 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620515} TBR=alph@chromium.org,erikchen@chromium.org Change-Id: I157cb9ac2899e10a445e0ab9004924d282b87d34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917476 Reviewed-on: https://chromium-review.googlesource.com/c/1400662 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#620671}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .