tree 865e0db4a52cdc13453b742e0ae4ba61dc45d65e
parent e7220dd6278306136fe289686eb3b3c9a93f62ac
author Florian Leimgruber <fleimgruber@google.com> 1697621941 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1697621941 +0000

Simplify Autofill ML model executor + handler

The ML code is structured as follows:
- The AutofillModelExecutor is responsible for converting the model
  input into a format that TFLite understand and converting the model
  output back to something that Autofill understands.
- The AutofillMlPredictionModelHandler is responsible for retrieving
  the model (e.g. from the server), loading it and asynchronously
  calling the executor.

This CL makes some minor simplifications to both classes, which will
simplify the follow-up CLs:
- Defines AutofillModelExecutor::Model(Input|Output) and replaces all
  hard coded instances of it. Follow-up CLs will change what the
  input/output types are.
- Early return in AutofillMlPredictionModelHandler::
  GetModelPredictionsForForm() when the model isn't available. This
  way, follow-up CLs can assume that everything was initialized
  correctly otherwise.
- Use the newish base::test::TestFuture<> instead of base::RunLoop in
  the executor unit test.

Bug: 1465926
Change-Id: I81a3f4a9db0052a33d659c5061d3f8b64926a371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4946691
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1211387}