commit | 693df943417bdf2311594213768dfd3ed6c84264 | [log] [tgz] |
---|---|---|
author | Anand K. Mistry <amistry@chromium.org> | Fri Feb 08 04:21:35 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 08 04:21:35 2019 |
tree | 4e27d00d0dae99884ea7be67d32eda85bb3b4549 | |
parent | 6d0d36a8d9dc2268c1db10f8f44342b80c81a5d4 [diff] |
Fix UAF in smb_client::MDnsHostLocator MDnsTransaction keeps a pointer to MDnsClient and accessed it on destruction. Therefore, it needs to be destroyed before MDnsClient. On the same note, destroy MDnsClient before MDnsSocketFactory because MDnsClient uses MDnsSocketFactory. This isn't strictly necessary, but keeping dependency order helps to prevent future UAF bugs. BUG=929467 Change-Id: I22af0ffa91b5bc2ce6533a8c0d85bfa351e8e9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1459861 Reviewed-by: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#630167}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .