Google Git
Sign in
chromium / chromium / src / 693f73fafe615cafdb652f4894270cc4dbd482c4
commit693f73fafe615cafdb652f4894270cc4dbd482c4[log] [tgz]
authorYuki Shiino <yukishiino@chromium.org>Fri Apr 19 14:55:17 2019
committerCommit Bot <commit-bot@chromium.org>Fri Apr 19 14:55:17 2019
treedb7e2f697193e081e149e90d76e2e44ff949978b
parentecdd7645f66837ede4b9fdaf1583e5e996cc3469 [diff]
v8binding: Fix ToFloat to throw

Adds a missing check of exception_state.HadException().

Comment about crbug.com/939598 is not correct because of
    unrestricted float (Web IDL) => ToFloat (Blink)
    float (Web IDL) => ToRestrictedFloat (Blink)
In case of 'unrestricted float', it shouldn't throw an
exception.

Bug: 939598
Change-Id: Ibda1cb445b630f38a8e3ab52c6839a49020d6941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574997
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652538}
1 file changed
tree: db7e2f697193e081e149e90d76e2e44ff949978b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .