commit 69e6bccb5d4d6b594708fbfac399134dac15e76f
author Jay Harris <harrisjay@chromium.org> Fri May 24 06:03:54 2019
committer Commit Bot <commit-bot@chromium.org> Fri May 24 06:03:54 2019
tree 3c2c8b394ead04f2acb6b986907eae207c5227ba
parent 8ad86466ecc74277d916a69088c67d9ee2944d7d

Fixes a bug where ChromeOS popups were incorrectly sized.

We weren't taking the TopContainer's (where the window close buttons live)
height into account. This adds the result of GetTopInset to
GetWindowBoundsFromClientBounds on ChromeOS, which other platforms were
doing already. In addition, it ensures that the FrameHeader is correctly
setup, so the size constraints will be correct.

Before and After screenshots for opening a 480x300px popup
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394786&signed_aid=1sRqzN7-EINNjSfsWHhj6A==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394787&signed_aid=EIwCu-QkBAjpW1dGVHvu_Q==&inline=1

A second CL (https://chromium-review.googlesource.com/c/chromium/src/+/1626441)
fixes a separate but related bug and adds tests to ensure this does not regress.

Bug: 777854
Change-Id: Ia4f9170a5bf538fd40bd1ce34056a5693f773047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626909
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662977}