Google Git
Sign in
chromium / chromium / src / 6aee02b02aaab3a6ef5cc5ed883f766e87146f16
commit6aee02b02aaab3a6ef5cc5ed883f766e87146f16[log] [tgz]
authorJoanmarie Diggs <jdiggs@igalia.com>Thu Apr 20 21:58:25 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 20 21:58:25 2023
treec12a7f7e55d226fdce461e2b0d8b5c1a0ec62efe
parenta066cf830783e068d612fdc4fda4593eddb38388 [diff]
Improve performance of HashMgr::InitHashEntry

Hunspell's HashMgr::InitHashEntry is called for every entry in the
dictionary. Each time it is called, it initializes a FileMgr object.
That FileMgr object is only used if there is a parser error. Should
there be an error, it reports the line number. However, because the
line number doesn't help identify the place which caused the parser
error in a BDICT file, FileMgr::getlinenum() always returns 0. Since
we don't actually need a unique FileMgr object in this scenario, make
it static. This improves performance in instances where the dictionary
is quite large (e.g. German).

Bug: 1432579
Change-Id: I05881b67df13430ca7613caef70d135f1fe63a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416960
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1133402}
3 files changed
tree: c12a7f7e55d226fdce461e2b0d8b5c1a0ec62efe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.