commit | 6afc4880a78e888a32df06df328386b1f7b31308 | [log] [tgz] |
---|---|---|
author | Noel Gordon <noel@chromium.org> | Thu Dec 06 05:38:43 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 06 05:38:43 2018 |
tree | 7d71e0243b633d1ad88a3f588c25f6334faf82f4 | |
parent | ba4cf64ec6d7268f1a6922c39198f5b419cbac6f [diff] |
Closure compile task_contoller_unittest - remove task_contoller_unittest.html - add BUILD rules to auto-generate and compile this unittest - define, install, and use mockChrome in the unittest code - use setupFileManagerPrivate() in all test cases - testExecuteEntryTask had its own local version but the test could also jsut use the common one: make it so. - make all test cases use the createTaskController helper - update JsDoc: a {FileSelectionHandler} is now required - remove the crostini create helper function - remove crostini.init call: no test cases depend on the crostini volume manager fake. - make createTaskController call createCrostiniForTest() when new-ing the {TaskController}. - make MockFileSelectionHandler @constructor, and @extends {FileSelectionHandler} interface, so createTaskController construction is both simple and type-safe. - add decriptive comments for each test case fixture - fix all Closure compiler errors, and auto-format JS code No change in test behavior, no new tests. Bug: 912410 Change-Id: I7a685533632860ce785b9aaca2e84b7c69579979 Reviewed-on: https://chromium-review.googlesource.com/c/1364270 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#614276}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .