Google Git
Sign in
chromium / chromium / src / 6bd4eac3f1a28ed0be473aa7f5c516328cf752eb
commit6bd4eac3f1a28ed0be473aa7f5c516328cf752eb[log] [tgz]
authorAlexander Dunaev <adunaev@igalia.com>Fri Dec 02 15:29:27 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 02 15:29:27 2022
tree6672930b9531b9b26df00cec38eb87288a4fd128
parentb2f97e38cbab7cc03e5af5480cc93f1098615a7f [diff]
[linux/wayland] Fixed how versions of objects are checked.

The recent change [1] demonstrated a wrong way to check the version when
deciding if the call is valid.  Instead of checking the compositor
version, we should check the object version.

The version mismatch makes the server terminating the client connection,
which happens on new Fedora that exposes the compositor version 5.
Chromium only claims version 4 at the moment, and upon starting the drag
the wayland protocol error happens.

This CL fixes two wrong checks.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4061548

Bug: 1253566, 1382126
Change-Id: I09cc8ee58bdba1a527e9bb8af11466b6ce3a3600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4075293
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Max Ihlenfeldt <max@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1078591}
2 files changed
tree: 6672930b9531b9b26df00cec38eb87288a4fd128
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.