commit | 6cab120126f8a1f7ddcaafb41d59e041a1c9e095 | [log] [tgz] |
---|---|---|
author | Friedrich Horschig <fhorschig@chromium.org> | Wed Jul 18 15:23:45 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jul 18 15:23:45 2018 |
tree | 1f50f4adb48aa01528dccff6e32f51399034615b | |
parent | 749d5ad29e15cfc91fb2652ba93baa6f744350d8 [diff] |
Reland "[Android] Change suggestions based on frame of focused field" This reverts commit 82c224b0aa0eed806ded736f5ad3fed09257926e. Reason for revert: The linked build (7968) wasn't the first broken build. The first broken build was 7959 where https://crrev.com/c/1139057 reenabled this known-to-be-flaky test (see issue 849582). dullweber@ takes care of the new revert. Original change's description: > Revert "[Android] Change suggestions based on frame of focused field" > > This reverts commit 4c9cbfb597cd0014ad5200b0a94cf0f13c466af6. > > Sorry for the revert -- this is failing on one of the ChromeOS builders: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/7968 > > You can see several failed tests in this log output: > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940668796232357776/+/steps/interactive_ui_tests/0/logs/All__x2f_PasswordManagerBrowserTestWithConditionalPopupViews.AutofillLoginSignupForm__x2f_1/0 > > > Original change's description: > > [Android] Change suggestions based on frame of focused field > > > > With this CL, the renderer notifies the password accessory controller > > when the focus moves to or away from valid input fields. > > > > Bug: 854152, 854150, 854149, 853742 > > Change-Id: I63f075ce238db8b77c784e945eea8ec83d8d4344 > > Reviewed-on: https://chromium-review.googlesource.com/1124466 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Reviewed-by: Mike West <mkwst@chromium.org> > > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575977} > > TBR=vasilii@chromium.org,dvadym@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org > > Change-Id: I01cc79e8dc98e29cbdb1a61c6da5a4cf021fcbfb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 854152, 854150, 854149, 853742 > Reviewed-on: https://chromium-review.googlesource.com/1141825 > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576042} TBR=vasilii@chromium.org,dvadym@chromium.org,iclelland@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org Change-Id: Idaadebd9b00179935c3f6347cc669c0811a912e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854152, 854150, 854149, 853742 Reviewed-on: https://chromium-review.googlesource.com/1141885 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#576066}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .