commit 6d77a353248d83cfcab9331a7e96d3f32fb1234b
author Vadym Doroshenko <dvadym@chromium.org> Tue Mar 05 14:00:23 2019
committer Commit Bot <commit-bot@chromium.org> Tue Mar 05 14:00:23 2019
tree 45e1b7b32f3807f300f3183dd28accae9063f8a7
parent 48e417a829d99eb94a3625b8fc867f3fa315b1e6

Revert "Fix caret rendering when at the end of a block after an ineditable inline"

This reverts commit e9aa20fd6702db58135773a650bc4cbd1c542350.

Reason for revert: this change breaks tests on win dbg bot

This is the first failure
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/6437

Test InsertListCommandTest.CleanupNodeSameAsDestinationNode is definitely fails because of this patch (I've verified it locally on Windows).
The problem with this test that it's very deep recursion in function between functions
AdjustBlockFlowPositionToInline
ComputeInlineAdjustedPositionAlgorithm

and as a result stack overflow.


Original change's description:
> Fix caret rendering when at the end of a block after an ineditable inline
>
> AdjustBlockFlowPositionToInline() has an early-reject branch that avoids
> infinite recursion, introduced in crrev.com/664b6437.
>
> However, the early reject condition is too aggressive that, it also
> rejects some positions that don't enter an infinite recursion, like
> the one used in the new unit test added in this CL.
>
> As now AdjustBlockFlowPositionToInline() has a hard limit on recursion
> depth, this CL safely removes the over-aggressive reject condition, so
> that caret can be correctly rendered for more positions.
>
> Note: Unit test InlineBoxPositionTest.ComputeInlineBoxPositionMixedEditable
> uses another position that doesn't enter the infinite loop but is falsely
> rejected by the condition. This patch allows caret rendering also for that
> position, and therefore changes its test expectation.
>
> Bug: 936988
> Change-Id: Idef91ffaa412e67cddd5fcf0dd61f54055de7189
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497466
> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#637311}

TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org

Change-Id: I6fcff118f27d633e627d5942671b04554fef283b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 936988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503579
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637676}