commit | 3d10bb3c11d46ad34b2fc304f93a0ae1a54c6d16 | [log] [tgz] |
---|---|---|
author | Rakina Zata Amni <rakina@chromium.org> | Fri Apr 19 03:12:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Apr 19 03:12:07 2019 |
tree | 23c04c2e2e5e5a1fc432879160aee80aee5b7955 | |
parent | 603bb8dfeeff79c16612ae9fe40e0c8a040ac3cc [diff] |
Change frame tree node traversal in FindRequestManager There's a bug in TraverseNext that might cause a node to traverse back to itself, even though it should've traversed to another node, triggering an infinite loop. This is caused by treating inner WebContents as children of the main frame, and potentially adding the same node as a child of multiple nodes. This CL changes the child/parent frame tree node traversal in FindManager, such that we won't encounter these cases anymore. Bug: 942346 Change-Id: I030492cb4c8a2aa330c71a15f9f337eb7ed0f3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530219 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652459}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .