commit | 6f53c4d2fdd7308b0eb60bc520bef5b7570fd930 | [log] [tgz] |
---|---|---|
author | Joanmarie Diggs <jdiggs@igalia.com> | Sat Jul 25 22:03:44 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Jul 25 22:03:44 2020 |
tree | 5d61f19d02b27eaaa7b3cfb9ba1f96e1057f785b | |
parent | 2edf00f84f2e91acab5b06a99fc2f085617cf0a9 [diff] |
Don't emit accessible text events from non-text or invisible objects Fixes three dcheck failures, each of which is related to attempting to emit AtkText events on objects which should not emit them. Therefore add checks to EmitsAtkTextEvents to ensure AtkText is implemented for the object, and that the object is not invisible or ignored. In addition: * For an HTMLMediaElement whose sole content is text (i.e. no player and no source), do not expose any children and treat as included but ignored. * Always include Role::kVideo and Role::kAudio in the internal accessibility tree, even when ignored, for consistency. AX-Relnotes: N/A as there is no change in end-user experience. Bug: 1041414, 1104047, 1104048 Change-Id: Id643f148fdaba3c865c6cefe8f20151c3181135b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297431 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791541}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.