commit | 6f5b37f0c16c07209fb42f5ada05c6db550c0189 | [log] [tgz] |
---|---|---|
author | Mario Sanchez Prada <mario@igalia.com> | Mon Jun 17 08:46:28 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jun 17 08:46:28 2019 |
tree | 1051c1b804987647566f10af6b9b82c4708a6d0f | |
parent | 82be265abc3248832f520bf3e5752684484b6a96 [diff] |
Convert PushMessaging implementation and clients to new Mojo types This converts the GetPushMessaging() method from DocumentInterfaceBroker along with the relevant parts of the implementation of mojom::PushMessaging at chrome::PushMessagingManager, and the two classes that use it from Blink, that is, blink::PushProvider and blink::PushMessagingClient. Note that, for now, this still relies on implicit conversions to get a PendingReceiver<T> from InterfaceRequest<T> in PushMessagingManager, which should go away once RenderProcessHostImpl has migrated away from service_manager::BinderRegistry, to service_manager::BinderMap. Also, it needs to keep using the InterfaceProvider in PushProvider to bind the remote interface to avoid thread-related issues that would happen if we tried to use service_manager::Connector now, since that requires being in the main thread to run Connect(), and that code usually runs from the ServiceWorker thread instead. This should stop being a problem once we have a ServiceWorkers-based InterfaceBroker, at which point the code can be fully migrated to service_manager::Connector. Bug: 955171 Change-Id: I62fb6d8b8e1a5872a14740260ea2bca14daf1a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655536 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#669593}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .