commit | 6f65bd26330cf709e4a4c4eb60876de5849f94d5 | [log] [tgz] |
---|---|---|
author | Luciano Pacheco <lucmult@chromium.org> | Wed Oct 17 05:10:44 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 17 05:10:44 2018 |
tree | b3fc8422eca55678ddf21b72f7102b47ac8a5698 | |
parent | 9f1edaca7c4050acc6aa60f0bdf10ae1a4a2b7f8 [diff] |
Files app: Select My files when there are no volumes Make Files app select "My files" when there are no available volumes, this to allow Files app to behave properly when volumes subsequently become available. Change DirectoryModel.onVolumeInfoListUpdated_ method to check for non-null |displayRoot| before trying to change to |displayRoot|. This fixes the error "Cannot read property 'getParent' of null" when Drive volume becomes available before the (default) Downloads volume/root. Change FakeDriveFs to unbind the two mojo bindings if they're bound, so DriveFsTestVolume can re-mount itself. Changes since revert: 1. Add a new function |getVolumesCount| to return the number of volumes available in the background page. 2. Add the new function above to wait for background page to have all volumes before un-mounting and wait it to unmount all volumes. 3. Change some logs from error to warn because errors are expected and handled when initializing volumes that are unmounting/unmounted in the backend. 4. Change selector used to click on Drive to actually wait for "My Drive" to be available. 5. A bit of more info in some logs around volume initialization. Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*" Bug: 893161, 884967, 894799 Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890 Reviewed-on: https://chromium-review.googlesource.com/c/1278619 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#600282}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .