commit | 6fec174a4a10919e1d46c41a69cbd80fdbfaddbd | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Mar 27 09:16:20 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Mar 27 09:16:20 2019 |
tree | 6029285ce347c909411e968a176b32e8d0967e5a | |
parent | 7d6ac29ac8b803c54b85f3c5f0bbe563af23e24a [diff] |
Allow the dep cycle chrome/browser/extensions <-> api_registration The generated api_registration files use a lot of headers in chrome/browser/extensions, creating a dependency cycle. I see no obvious way to break the cycle so this just makes it official. There were also a couple of files in chrome/browser/accessibility which were used from api registration, creating an unpleasant dependency. That was fixed by putting those files in extensions instead of in chrome/browser. The missing dependencies triggered a lot of gn errors with a gn fixed to look at generated files (gn:57). The list is about 60 reports like: ERROR at //out/Default/gen/chrome/browser/extensions/api/generated_api_registration.cc:7:11: Include not allowed. ^-------------------------------------------------------------------------------- It is not in any dependency of //chrome/browser/extensions/api:api_registration The include file is in the target(s): //chrome/browser/extensions:extensions which should somehow be reachable. Bug: 655123 Change-Id: Ifc7809de17c9a426d2a6abdb41ecc42996b0d01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529095 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644715}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .