tabdrag: Fix tabstrip layout when dragging out of a maximized window

When a tab is dragged out of a maximized window, the detached window is
created in restored state (ie: with different geometry) and tab drag
controller needs to adjust the window and dragged tabs' bounds (more
specifically x location), so that they appear under the pointer. That's
done at TabStrip::TabDragContextImpl::SetBoundsForDrag() function [2],
which calls into Views::SetBoundsRect() for each selected Tab view. It
turns out that it is not enough to ensure the tabstrip and its parent,
TabStripRegionView, get properly re-laid out, leading to issues like
[1], where the dragged tab gets partially or totally occluded by the
TabStripRegionView's child views.

To fix it, this CL adds layout invalidation for tab strip just after
setting bounds rect for each dragged tabs, ensuring both tab strip and
its parent views are correctly relaid out.

Bug: 1151092

[1] https://drive.google.com/file/d/1a6kEVy0DNUo9TTeiCYjkpf7d42TI3T7n
[2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_strip.cc;l=697-708;drc=d81c5852498699fe3cd812e78d31c77c28e29281

R=sky@chromium.org

Change-Id: I51244ad4485856334ce3443ed92ce80e2fad2cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572040
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843781}
2 files changed
tree: a189dc0a1e560a84a6b2744d34f5bde32cd33cb8
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. DIR_METADATA
  16. ENG_REVIEW_OWNERS
  17. LICENSE
  18. LICENSE.chromium_os
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. PRESUBMIT_test_mocks.py
  23. README.md
  24. WATCHLISTS
  25. android_webview/
  26. apps/
  27. ash/
  28. base/
  29. build/
  30. build_overrides/
  31. buildtools/
  32. cc/
  33. chrome/
  34. chromecast/
  35. chromeos/
  36. cloud_print/
  37. codelabs/
  38. codereview.settings
  39. components/
  40. content/
  41. courgette/
  42. crypto/
  43. dbus/
  44. device/
  45. docs/
  46. extensions/
  47. fuchsia/
  48. gin/
  49. google_apis/
  50. google_update/
  51. gpu/
  52. headless/
  53. infra/
  54. ios/
  55. ipc/
  56. jingle/
  57. media/
  58. mojo/
  59. native_client_sdk/
  60. net/
  61. pdf/
  62. ppapi/
  63. printing/
  64. remoting/
  65. rlz/
  66. sandbox/
  67. services/
  68. skia/
  69. sql/
  70. storage/
  71. styleguide/
  72. testing/
  73. third_party/
  74. tools/
  75. ui/
  76. url/
  77. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.