commit | 716846ea95ea93bcdc72469c54eb811888bb4907 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Feb 19 23:23:40 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 19 23:23:40 2019 |
tree | fe31936f31130e26fc8f1b1f9b7de3743de5d0fe | |
parent | 12e95c0f01f34af021402a0a497e7edbc7019476 [diff] |
Add dependency ipc_fuzzer -> chrome_elf:test_stubs On Windows, ipc_fuzzer uses chrome/common/child_process_logging_win.cc which uses the SetMetricsClientId() function from //chrome_elf. There is intentionally no dependency in chrome/common to allow different products to select between the sharp chrome_elf code and the test version of chrome_elf. In common builds this missing dependency does not cause any build failures, probably because child_process_logging_win.obj will be ignored by the linker completely since ipc_fuzzer uses nothing in that object file. That was not the case in some jumbo build experiments. The end result will most likely be the same. Change-Id: I6607423e46270f256d67758b1bad087927de2edf Reviewed-on: https://chromium-review.googlesource.com/c/1443017 Reviewed-by: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Martin Barbella <mbarbella@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#633447}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .