commit | 7187f86e3cfd06220ef7f36ee0efc809988cd45c | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Mon Dec 10 11:17:31 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Dec 10 11:17:31 2018 |
tree | 681326b9ec68fa161c7f4928c3899a6ce012af6f | |
parent | 1af3bb6d37fdbb89e5375d3502574cb9e58740e6 [diff] |
Don't prefix absolute paths in gn_run_binary.py. Absolute paths become broken paths if prefixed with ./ so only do the ./ addition for non-absolute paths. The result would be that the command failed with: "WindowsError: [Error 2] The system cannot find the file specified" on the command execution. This could easily be misunderstood as some argument to the command being wrong. You get absolute paths in gn when using rebase_path(path) with no extra arguments. This is the recommended and supported way to interact with external programs since gn internal paths can contain and be based on "//" which is not understood by anyone but gn internally. Change-Id: I2ab49f529c7d030f73f693e5ea6cacc5ebbf3c99 Reviewed-on: https://chromium-review.googlesource.com/c/1367670 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615087}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .