Google Git
Sign in
chromium / chromium / src / 9f1465fc2d48f0b57fcd3bddc9da45946c97fe5d
commit9f1465fc2d48f0b57fcd3bddc9da45946c97fe5d[log] [tgz]
authorrbpotter <rbpotter@chromium.org>Tue Mar 19 16:17:35 2019
committerCommit Bot <commit-bot@chromium.org>Tue Mar 19 16:17:35 2019
treea4e8befb3c8d8394623981f43eaf5f0bc9cf7f42
parent285c0a320262d72c4861686c0e670e2db0c90a26 [diff]
Custom Margins: Default to 0 for missing values

Tolerate non-existent custom margins values in C++, by setting the
margin field to 0 if it does not exist. This will prevent the crashes
in the linked bug, and is safer than merging larger changes to the
Print Preview JS that will prevent this from happening.

This is a short term workaround; we will change this back to a stricter
check after landing larger changes in Print Preview JS to prevent bad
custom margin values from being sent.

Bug: 942211
Change-Id: I978fdf65519efc0d6a0d6379c2266e330908fc0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529314
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642002}
1 file changed
tree: a4e8befb3c8d8394623981f43eaf5f0bc9cf7f42
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .