Google Git
Sign in
chromium / chromium / src / 74132fcd943d3e50e97cb71ae2ec9b95da3e064c
commit74132fcd943d3e50e97cb71ae2ec9b95da3e064c[log] [tgz]
authordpapad <dpapad@chromium.org>Fri Feb 08 13:09:48 2019
committerCommit Bot <commit-bot@chromium.org>Fri Feb 08 13:09:48 2019
tree35fbd443b36a3fed937000d4cd004685b5d0ad8d
parent12fb3f13540d9ca468323a71ccaa87d22081b583 [diff]
Settings WebUI: Tweak logic that shows sync cancel dialog.

The code was triggering a navigation from within a currentRouteChanged
observer, which triggers another round of observer notifications, which
resulted in observers getting in a weird state.

Unfortunately triggering a navigation from within such an observer is not
well suported from the routing mechanism (no such use case previously AFAIK).

Fixed by yielding first, such that all observers finish, before triggering
a new navigation.

Bug: 929026
Change-Id: Iee89af435bb2c8a7c738622abdc45d568173d07b
Reviewed-on: https://chromium-review.googlesource.com/c/1460398
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630287}
2 files changed
tree: 35fbd443b36a3fed937000d4cd004685b5d0ad8d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .