Google Git
Sign in
chromium / chromium / src / 749ce2e8a842554ff6dc1fc730a765473fabed82
commit749ce2e8a842554ff6dc1fc730a765473fabed82[log] [tgz]
authorJenny Zhang <jennyz@chromium.org>Tue Feb 12 19:54:48 2019
committerCommit Bot <commit-bot@chromium.org>Tue Feb 12 19:54:48 2019
tree617e670dc2bc8eae3d78596a0653b7b9fce6e4de
parent6da8ca7aaecd61fb96f7183ba7bc959d26dffd6f [diff]
Fix the DCHECK failures under zero state.

The DCHECK failures in components/omnibox code are caused by
not expecting empty input from zero state, and the case that there
should not be any default match for zero state suggestions.

Also fix another DCHECK failure caused by incorrect use of
UMA_HISTOGRAM_TIMES in recording OmniboxProvider latency code.

Bug: 925607, 920770
Change-Id: If643a564b94c8c429b4bb570593c35c5a2c36b6a
Reviewed-on: https://chromium-review.googlesource.com/c/1461343
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631347}
3 files changed
tree: 617e670dc2bc8eae3d78596a0653b7b9fce6e4de
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .