Avoid having two GetSyncedFaviconForPageURL in chrome/browser/ui

In certain non-default extreme jumbo build the
GetSyncedFaviconForPageURL in recent_tabs_sub_menu_model.cc
ended up in the same translation unit as the
GetSyncedFaviconForPageURL in favicon_source.cc and then it did not
compile. The methods are similar but not identical so they
cannot be shared as is.

This renames one of the functions
GetSyncedFaviconForPageURL -> RecentTabsGetSyncedFaviconForPageURL

Bug: 955475
Change-Id: I48c9ac701b0071b71f719afffb19c65687258410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617458
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661416}
1 file changed