tree 8d6062b0738c8a92b17b13f1de93126f4a5a68d6
parent b49d8f2b95dc0e3d246c9ed5f0cb188db9e6bc96
author Christoph Schwering <schwering@google.com> 1648135419 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1648135419 +0000

[Autofill] Refactor FormStructure::EncodeUploadRequest().

This CL is a preparation for a followup CL that extends voting
to renderer forms (crrev.com/c/3539862). It refactors some parts
of EncodeUploadRequest() and its helper EncodeFormForUpload():

1. Streamlines the EncodeUploadRequest() API: the out-parameter
  `upload` is now a return value, and deletes the out-parameter
  `encoded_signatures` without substitution.
2. The return value is a vector of AutofillUploadContents rather
   than just a single value. For now, this vector as 0 or 1 elements,
   but the followup CL mentioned above will produce longer vectors.
3. Leaves only the field-specific parts in EncodeFormForUpload() and
   renames it to EncodeFormFieldsForUpload().
4. Introduces a matcher in form_structure_unittest.cc.

Bug: 1007974
Change-Id: Icf2ed82630eda462ea3df6135cdec71405654b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536663
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#984838}