chrome/browser/about_flags_browsertest.cc - chromium/src - Git at Google

 // Copyright 2018 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/bind_test_util.h"
 #include "base/test/scoped_feature_list.h"
 #include "build/build_config.h"
 #include "chrome/browser/about_flags.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/unexpire_flags.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/flags_ui/feature_entry_macros.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "ui/base/window_open_disposition.h"

 namespace {

 const char kSwitchName[] = "flag-system-test-switch";
 const char kFlagName[] = "flag-system-test-flag-1";

 const char kExpiredFlagName[] = "flag-system-test-flag-2";
 const char kExpiredFlagSwitchName[] = "flag-system-test-expired-switch";

 const char kFlagWithOptionSelectorName[] = "flag-system-test-flag-3";
 const char kFlagWithOptionSelectorSwitchName[] = "flag-system-test-switch";

 // Command line switch containing an invalid origin.
 const char kUnsanitizedCommandLine[] =
     "http://example-cmdline.test,invalid-cmdline";

 // Command line switch without the invalid origin.
 const char kSanitizedCommandLine[] = "http://example-cmdline.test";

 // User input containing invalid origins.
 const char kUnsanitizedInput[] =
     "http://example.test/path    http://example2.test/?query\n"
     "invalid-value, filesystem:http://example.test.file, "
     "ws://example3.test http://&^.com";

 // User input with invalid origins removed and formatted.
 const char kSanitizedInput[] =
     "http://example.test,http://example2.test,ws://example3.test";

 // Command Line + user input with invalid origins removed and formatted.
 const char kSanitizedInputAndCommandLine[] =
     "http://example-cmdline.test,http://example.test,http://"
     "example2.test,ws://example3.test";

 void SimulateTextType(content::WebContents* contents,
                       const char* experiment_id,
                       const char* text) {
   EXPECT_TRUE(content::ExecuteScript(
       contents, base::StringPrintf(
                     "var parent = document.getElementById('%s');"
                     "var textarea = parent.getElementsByTagName('textarea')[0];"
                     "textarea.focus();"
                     "textarea.value = `%s`;"
                     "textarea.onchange();",
                     experiment_id, text)));
 }

 void ToggleEnableDropdown(content::WebContents* contents,
                           const char* experiment_id,
                           bool enable) {
   EXPECT_TRUE(content::ExecuteScript(
       contents,
       base::StringPrintf(
           "var k = document.getElementById('%s');"
           "var s = k.getElementsByClassName('experiment-enable-disable')[0];"
           "s.focus();"
           "s.selectedIndex = %d;"
           "s.onchange();",
           experiment_id, enable ? 1 : 0)));
 }

 std::string GetOriginListText(content::WebContents* contents,
                               const char* experiment_id) {
   std::string text;
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(
       contents,
       base::StringPrintf(
           "var k = document.getElementById('%s');"
           "var s = k.getElementsByClassName('experiment-origin-list-value')[0];"
           "window.domAutomationController.send(s.value );",
           experiment_id),
       &text));
   return text;
 }

 bool IsDropdownEnabled(content::WebContents* contents,
                        const char* experiment_id) {
   bool result = false;
   EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
       contents,
       base::StringPrintf(
           "var k = document.getElementById('%s');"
           "var s = k.getElementsByClassName('experiment-enable-disable')[0];"
           "window.domAutomationController.send(s.value == 'enabled');",
           experiment_id),
       &result));
   return result;
 }

 bool IsFlagPresent(content::WebContents* contents, const char* experiment_id) {
   bool result = false;
   EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
       contents,
       base::StringPrintf("var k = document.getElementById('%s');"
                          "window.domAutomationController.send(k != null);",
                          experiment_id),
       &result));
   return result;
 }

 void WaitForExperimentalFeatures(content::WebContents* contents) {
   bool unused;
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
       contents,
       "experimentalFeaturesReady.then(() => {"
       "  window.domAutomationController.send(true);"
       "});",
       &unused));
 }

 // In these tests, valid origins in the existing command line flag will be
 // appended to the list entered by the user in chrome://flags.
 // The tests are run twice for each bool value: Once with an existing command
 // line (provided in SetUpCommandLine) and once without.
 class AboutFlagsBrowserTest : public InProcessBrowserTest,
                               public testing::WithParamInterface<bool> {
  public:
   AboutFlagsBrowserTest() {
     about_flags::testing::SetFeatureEntries(
         {{kFlagName, "name-1", "description-1", -1,
           ORIGIN_LIST_VALUE_TYPE(kSwitchName, "")},
          {kExpiredFlagName, "name-2", "description-2", -1,
           SINGLE_VALUE_TYPE(kExpiredFlagSwitchName)},
          {kFlagWithOptionSelectorName, "name-3", "description-3", -1,
           SINGLE_VALUE_TYPE(kFlagWithOptionSelectorSwitchName)}});
     flags::testing::SetFlagExpiredPredicate(
         base::BindLambdaForTesting([&](const std::string& name) -> bool {
           return expiration_enabled_ && name == kExpiredFlagName;
         }));
   }

   void SetUpCommandLine(base::CommandLine* command_line) override {
     command_line->AppendSwitchASCII(kSwitchName, GetInitialCommandLine());
   }

  protected:
   void set_expiration_enabled(bool enabled) { expiration_enabled_ = enabled; }

   bool has_initial_command_line() const { return GetParam(); }

   std::string GetInitialCommandLine() const {
     return has_initial_command_line() ? kUnsanitizedCommandLine : std::string();
   }

   std::string GetSanitizedCommandLine() const {
     return has_initial_command_line() ? kSanitizedCommandLine : std::string();
   }

   std::string GetSanitizedInputAndCommandLine() const {
     return has_initial_command_line() ? kSanitizedInputAndCommandLine
                                       : kSanitizedInput;
   }

   void NavigateToFlagsPage() {
     ui_test_utils::NavigateToURL(browser(), GURL("chrome://flags"));
     WaitForExperimentalFeatures(
         browser()->tab_strip_model()->GetActiveWebContents());
   }

   bool expiration_enabled_ = true;

   base::test::ScopedFeatureList feature_list_;
 };

 INSTANTIATE_TEST_SUITE_P(All,
                          AboutFlagsBrowserTest,
                          ::testing::Values(true, false));

 // Goes to chrome://flags page, types text into an ORIGIN_LIST_VALUE field but
 // does not enable the feature.
 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, PRE_OriginFlagDisabled) {
   NavigateToFlagsPage();

   const base::CommandLine::SwitchMap kInitialSwitches =
       base::CommandLine::ForCurrentProcess()->GetSwitches();

   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();

   // The page should be populated with the sanitized command line value.
   EXPECT_EQ(GetSanitizedCommandLine(), GetOriginListText(contents, kFlagName));

   // Type a value in the experiment's textarea. Since the flag state is
   // "Disabled" by default, command line shouldn't change.
   SimulateTextType(contents, kFlagName, kUnsanitizedInput);
   EXPECT_EQ(kInitialSwitches,
             base::CommandLine::ForCurrentProcess()->GetSwitches());

   // Input should be restored after a page reload.
   NavigateToFlagsPage();
   EXPECT_EQ(GetSanitizedInputAndCommandLine(),
             GetOriginListText(contents, kFlagName));
 }

 // Flaky. http://crbug.com/1010678
 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, DISABLED_OriginFlagDisabled) {
   // Even though the feature is disabled, the switch is set directly via command
   // line.
   EXPECT_EQ(
       GetInitialCommandLine(),
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));

   NavigateToFlagsPage();
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_FALSE(IsDropdownEnabled(contents, kFlagName));
   EXPECT_EQ(GetSanitizedInputAndCommandLine(),
             GetOriginListText(contents, kFlagName));
 }

 // Goes to chrome://flags page, types text into an ORIGIN_LIST_VALUE field and
 // enables the feature.
 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, PRE_OriginFlagEnabled) {
   NavigateToFlagsPage();

   const base::CommandLine::SwitchMap kInitialSwitches =
       base::CommandLine::ForCurrentProcess()->GetSwitches();

   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();

   // The page should be populated with the sanitized command line value.
   EXPECT_EQ(GetSanitizedCommandLine(), GetOriginListText(contents, kFlagName));

   // Type a value in the experiment's textarea. Since the flag state is
   // "Disabled" by default, command line shouldn't change.
   SimulateTextType(contents, kFlagName, kUnsanitizedInput);
   EXPECT_EQ(kInitialSwitches,
             base::CommandLine::ForCurrentProcess()->GetSwitches());

   // Enable the experiment. The behavior is different between ChromeOS and
   // non-ChromeOS.
   ToggleEnableDropdown(contents, kFlagName, true);

 #if !defined(OS_CHROMEOS)
   // On non-ChromeOS, the command line is not modified until restart.
   EXPECT_EQ(kInitialSwitches,
             base::CommandLine::ForCurrentProcess()->GetSwitches());
 #else
   // On ChromeOS, the command line is immediately modified.
   EXPECT_NE(kInitialSwitches,
             base::CommandLine::ForCurrentProcess()->GetSwitches());
   EXPECT_EQ(
       GetSanitizedInputAndCommandLine(),
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
 #endif

   // Input should be restored after a page reload.
   NavigateToFlagsPage();
   EXPECT_EQ(GetSanitizedInputAndCommandLine(),
             GetOriginListText(contents, kFlagName));
 }

 // Flaky. http://crbug.com/1010678
 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, DISABLED_OriginFlagEnabled) {
 #if !defined(OS_CHROMEOS)
   // On non-ChromeOS, the command line is modified after restart.
   EXPECT_EQ(
       GetSanitizedInputAndCommandLine(),
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
 #else
   // On ChromeOS, the command line isn't modified after restart.
   EXPECT_EQ(
       GetInitialCommandLine(),
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
 #endif

   NavigateToFlagsPage();
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(IsDropdownEnabled(contents, kFlagName));
   EXPECT_EQ(GetSanitizedInputAndCommandLine(),
             GetOriginListText(contents, kFlagName));

 #if defined(OS_CHROMEOS)
   // ChromeOS doesn't read chrome://flags values on startup so we explicitly
   // need to disable and re-enable the flag here.
   ToggleEnableDropdown(contents, kFlagName, true);
 #endif

   EXPECT_EQ(
       GetSanitizedInputAndCommandLine(),
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
 }

 // Crashes on Win.  http://crbug.com/1025213
 #if defined(OS_WIN)
 #define MAYBE_ExpiryHidesFlag DISABLED_ExpiryHidesFlag
 #else
 #define MAYBE_ExpiryHidesFlag ExpiryHidesFlag
 #endif
 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, MAYBE_ExpiryHidesFlag) {
   NavigateToFlagsPage();
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(IsFlagPresent(contents, kFlagName));
   EXPECT_FALSE(IsFlagPresent(contents, kExpiredFlagName));

   set_expiration_enabled(false);

   NavigateToFlagsPage();
   contents = browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(IsFlagPresent(contents, kFlagName));
   EXPECT_TRUE(IsFlagPresent(contents, kExpiredFlagName));
 }

 #if !defined(OS_CHROMEOS)
 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, PRE_ExpiredFlagDoesntApply) {
   set_expiration_enabled(false);
   NavigateToFlagsPage();
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(IsFlagPresent(contents, kExpiredFlagName));
   EXPECT_FALSE(IsDropdownEnabled(contents, kExpiredFlagName));

   ToggleEnableDropdown(contents, kExpiredFlagName, true);
 }

 // Flaky everywhere: https://crbug.com/1024028
 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, DISABLED_ExpiredFlagDoesntApply) {
   set_expiration_enabled(true);
   NavigateToFlagsPage();
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_FALSE(IsFlagPresent(contents, kExpiredFlagName));

   EXPECT_FALSE(base::CommandLine::ForCurrentProcess()->HasSwitch(
       kExpiredFlagSwitchName));
 }
 #endif

 IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, FormRestore) {
   NavigateToFlagsPage();
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();

   // Remove the internal_name property from a flag's selector, then synthesize a
   // change event for it. This simulates what happens during form restoration in
   // Blink, when navigating back and then forward to the flags page. This test
   // ensures that that does not crash the browser.
   // See https://crbug.com/1038638 for more details.
   EXPECT_TRUE(content::ExecJs(
       contents,
       base::StringPrintf(
           "var k = document.getElementById('%s');"
           "var s = k.getElementsByClassName('experiment-enable-disable')[0];"
           "delete s.internal_name;"
           "const e = document.createEvent('HTMLEvents');"
           "e.initEvent('change', true, true);"
           "s.dispatchEvent(e);",
           kFlagWithOptionSelectorName)));
 }

 }  // namespace
	// Copyright 2018 The Chromium Authors. All rights reserved.
	// Use of this source code is governed by a BSD-style license that can be
	// found in the LICENSE file.

	#include "base/command_line.h"
	#include "base/strings/stringprintf.h"
	#include "base/strings/utf_string_conversions.h"
	#include "base/test/bind_test_util.h"
	#include "base/test/scoped_feature_list.h"
	#include "build/build_config.h"
	#include "chrome/browser/about_flags.h"
	#include "chrome/browser/ui/browser.h"
	#include "chrome/browser/ui/tabs/tab_strip_model.h"
	#include "chrome/browser/unexpire_flags.h"
	#include "chrome/test/base/in_process_browser_test.h"
	#include "chrome/test/base/interactive_test_utils.h"
	#include "chrome/test/base/ui_test_utils.h"
	#include "components/flags_ui/feature_entry_macros.h"
	#include "content/public/browser/web_contents.h"
	#include "content/public/test/browser_test_utils.h"
	#include "ui/base/window_open_disposition.h"

	namespace {

	const char kSwitchName[] = "flag-system-test-switch";
	const char kFlagName[] = "flag-system-test-flag-1";

	const char kExpiredFlagName[] = "flag-system-test-flag-2";
	const char kExpiredFlagSwitchName[] = "flag-system-test-expired-switch";

	const char kFlagWithOptionSelectorName[] = "flag-system-test-flag-3";
	const char kFlagWithOptionSelectorSwitchName[] = "flag-system-test-switch";

	// Command line switch containing an invalid origin.
	const char kUnsanitizedCommandLine[] =
	"http://example-cmdline.test,invalid-cmdline";

	// Command line switch without the invalid origin.
	const char kSanitizedCommandLine[] = "http://example-cmdline.test";

	// User input containing invalid origins.
	const char kUnsanitizedInput[] =
	"http://example.test/path http://example2.test/?query\n"
	"invalid-value, filesystem:http://example.test.file, "
	"ws://example3.test http://&^.com";

	// User input with invalid origins removed and formatted.
	const char kSanitizedInput[] =
	"http://example.test,http://example2.test,ws://example3.test";

	// Command Line + user input with invalid origins removed and formatted.
	const char kSanitizedInputAndCommandLine[] =
	"http://example-cmdline.test,http://example.test,http://"
	"example2.test,ws://example3.test";

	void SimulateTextType(content::WebContents* contents,
	const char* experiment_id,
	const char* text) {
	EXPECT_TRUE(content::ExecuteScript(
	contents, base::StringPrintf(
	"var parent = document.getElementById('%s');"
	"var textarea = parent.getElementsByTagName('textarea')[0];"
	"textarea.focus();"
	"textarea.value = `%s`;"
	"textarea.onchange();",
	experiment_id, text)));
	}

	void ToggleEnableDropdown(content::WebContents* contents,
	const char* experiment_id,
	bool enable) {
	EXPECT_TRUE(content::ExecuteScript(
	contents,
	base::StringPrintf(
	"var k = document.getElementById('%s');"
	"var s = k.getElementsByClassName('experiment-enable-disable')[0];"
	"s.focus();"
	"s.selectedIndex = %d;"
	"s.onchange();",
	experiment_id, enable ? 1 : 0)));
	}

	std::string GetOriginListText(content::WebContents* contents,
	const char* experiment_id) {
	std::string text;
	EXPECT_TRUE(content::ExecuteScriptAndExtractString(
	contents,
	base::StringPrintf(
	"var k = document.getElementById('%s');"
	"var s = k.getElementsByClassName('experiment-origin-list-value')[0];"
	"window.domAutomationController.send(s.value );",
	experiment_id),
	&text));
	return text;
	}

	bool IsDropdownEnabled(content::WebContents* contents,
	const char* experiment_id) {
	bool result = false;
	EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
	contents,
	base::StringPrintf(
	"var k = document.getElementById('%s');"
	"var s = k.getElementsByClassName('experiment-enable-disable')[0];"
	"window.domAutomationController.send(s.value == 'enabled');",
	experiment_id),
	&result));
	return result;
	}

	bool IsFlagPresent(content::WebContents* contents, const char* experiment_id) {
	bool result = false;
	EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
	contents,
	base::StringPrintf("var k = document.getElementById('%s');"
	"window.domAutomationController.send(k != null);",
	experiment_id),
	&result));
	return result;
	}

	void WaitForExperimentalFeatures(content::WebContents* contents) {
	bool unused;
	ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
	contents,
	"experimentalFeaturesReady.then(() => {"
	" window.domAutomationController.send(true);"
	"});",
	&unused));
	}

	// In these tests, valid origins in the existing command line flag will be
	// appended to the list entered by the user in chrome://flags.
	// The tests are run twice for each bool value: Once with an existing command
	// line (provided in SetUpCommandLine) and once without.
	class AboutFlagsBrowserTest : public InProcessBrowserTest,
	public testing::WithParamInterface<bool> {
	public:
	AboutFlagsBrowserTest() {
	about_flags::testing::SetFeatureEntries(
	{{kFlagName, "name-1", "description-1", -1,
	ORIGIN_LIST_VALUE_TYPE(kSwitchName, "")},
	{kExpiredFlagName, "name-2", "description-2", -1,
	SINGLE_VALUE_TYPE(kExpiredFlagSwitchName)},
	{kFlagWithOptionSelectorName, "name-3", "description-3", -1,
	SINGLE_VALUE_TYPE(kFlagWithOptionSelectorSwitchName)}});
	flags::testing::SetFlagExpiredPredicate(
	base::BindLambdaForTesting([&](const std::string& name) -> bool {
	return expiration_enabled_ && name == kExpiredFlagName;
	}));
	}

	void SetUpCommandLine(base::CommandLine* command_line) override {
	command_line->AppendSwitchASCII(kSwitchName, GetInitialCommandLine());
	}

	protected:
	void set_expiration_enabled(bool enabled) { expiration_enabled_ = enabled; }

	bool has_initial_command_line() const { return GetParam(); }

	std::string GetInitialCommandLine() const {
	return has_initial_command_line() ? kUnsanitizedCommandLine : std::string();
	}

	std::string GetSanitizedCommandLine() const {
	return has_initial_command_line() ? kSanitizedCommandLine : std::string();
	}

	std::string GetSanitizedInputAndCommandLine() const {
	return has_initial_command_line() ? kSanitizedInputAndCommandLine
	: kSanitizedInput;
	}

	void NavigateToFlagsPage() {
	ui_test_utils::NavigateToURL(browser(), GURL("chrome://flags"));
	WaitForExperimentalFeatures(
	browser()->tab_strip_model()->GetActiveWebContents());
	}

	bool expiration_enabled_ = true;

	base::test::ScopedFeatureList feature_list_;
	};

	INSTANTIATE_TEST_SUITE_P(All,
	AboutFlagsBrowserTest,
	::testing::Values(true, false));

	// Goes to chrome://flags page, types text into an ORIGIN_LIST_VALUE field but
	// does not enable the feature.
	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, PRE_OriginFlagDisabled) {
	NavigateToFlagsPage();

	const base::CommandLine::SwitchMap kInitialSwitches =
	base::CommandLine::ForCurrentProcess()->GetSwitches();

	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();

	// The page should be populated with the sanitized command line value.
	EXPECT_EQ(GetSanitizedCommandLine(), GetOriginListText(contents, kFlagName));

	// Type a value in the experiment's textarea. Since the flag state is
	// "Disabled" by default, command line shouldn't change.
	SimulateTextType(contents, kFlagName, kUnsanitizedInput);
	EXPECT_EQ(kInitialSwitches,
	base::CommandLine::ForCurrentProcess()->GetSwitches());

	// Input should be restored after a page reload.
	NavigateToFlagsPage();
	EXPECT_EQ(GetSanitizedInputAndCommandLine(),
	GetOriginListText(contents, kFlagName));
	}

	// Flaky. http://crbug.com/1010678
	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, DISABLED_OriginFlagDisabled) {
	// Even though the feature is disabled, the switch is set directly via command
	// line.
	EXPECT_EQ(
	GetInitialCommandLine(),
	base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));

	NavigateToFlagsPage();
	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();
	EXPECT_FALSE(IsDropdownEnabled(contents, kFlagName));
	EXPECT_EQ(GetSanitizedInputAndCommandLine(),
	GetOriginListText(contents, kFlagName));
	}

	// Goes to chrome://flags page, types text into an ORIGIN_LIST_VALUE field and
	// enables the feature.
	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, PRE_OriginFlagEnabled) {
	NavigateToFlagsPage();

	const base::CommandLine::SwitchMap kInitialSwitches =
	base::CommandLine::ForCurrentProcess()->GetSwitches();

	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();

	// The page should be populated with the sanitized command line value.
	EXPECT_EQ(GetSanitizedCommandLine(), GetOriginListText(contents, kFlagName));

	// Type a value in the experiment's textarea. Since the flag state is
	// "Disabled" by default, command line shouldn't change.
	SimulateTextType(contents, kFlagName, kUnsanitizedInput);
	EXPECT_EQ(kInitialSwitches,
	base::CommandLine::ForCurrentProcess()->GetSwitches());

	// Enable the experiment. The behavior is different between ChromeOS and
	// non-ChromeOS.
	ToggleEnableDropdown(contents, kFlagName, true);

	#if !defined(OS_CHROMEOS)
	// On non-ChromeOS, the command line is not modified until restart.
	EXPECT_EQ(kInitialSwitches,
	base::CommandLine::ForCurrentProcess()->GetSwitches());
	#else
	// On ChromeOS, the command line is immediately modified.
	EXPECT_NE(kInitialSwitches,
	base::CommandLine::ForCurrentProcess()->GetSwitches());
	EXPECT_EQ(
	GetSanitizedInputAndCommandLine(),
	base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
	#endif

	// Input should be restored after a page reload.
	NavigateToFlagsPage();
	EXPECT_EQ(GetSanitizedInputAndCommandLine(),
	GetOriginListText(contents, kFlagName));
	}

	// Flaky. http://crbug.com/1010678
	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, DISABLED_OriginFlagEnabled) {
	#if !defined(OS_CHROMEOS)
	// On non-ChromeOS, the command line is modified after restart.
	EXPECT_EQ(
	GetSanitizedInputAndCommandLine(),
	base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
	#else
	// On ChromeOS, the command line isn't modified after restart.
	EXPECT_EQ(
	GetInitialCommandLine(),
	base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
	#endif

	NavigateToFlagsPage();
	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();
	EXPECT_TRUE(IsDropdownEnabled(contents, kFlagName));
	EXPECT_EQ(GetSanitizedInputAndCommandLine(),
	GetOriginListText(contents, kFlagName));

	#if defined(OS_CHROMEOS)
	// ChromeOS doesn't read chrome://flags values on startup so we explicitly
	// need to disable and re-enable the flag here.
	ToggleEnableDropdown(contents, kFlagName, true);
	#endif

	EXPECT_EQ(
	GetSanitizedInputAndCommandLine(),
	base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kSwitchName));
	}

	// Crashes on Win. http://crbug.com/1025213
	#if defined(OS_WIN)
	#define MAYBE_ExpiryHidesFlag DISABLED_ExpiryHidesFlag
	#else
	#define MAYBE_ExpiryHidesFlag ExpiryHidesFlag
	#endif
	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, MAYBE_ExpiryHidesFlag) {
	NavigateToFlagsPage();
	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();
	EXPECT_TRUE(IsFlagPresent(contents, kFlagName));
	EXPECT_FALSE(IsFlagPresent(contents, kExpiredFlagName));

	set_expiration_enabled(false);

	NavigateToFlagsPage();
	contents = browser()->tab_strip_model()->GetActiveWebContents();
	EXPECT_TRUE(IsFlagPresent(contents, kFlagName));
	EXPECT_TRUE(IsFlagPresent(contents, kExpiredFlagName));
	}

	#if !defined(OS_CHROMEOS)
	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, PRE_ExpiredFlagDoesntApply) {
	set_expiration_enabled(false);
	NavigateToFlagsPage();
	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();
	EXPECT_TRUE(IsFlagPresent(contents, kExpiredFlagName));
	EXPECT_FALSE(IsDropdownEnabled(contents, kExpiredFlagName));

	ToggleEnableDropdown(contents, kExpiredFlagName, true);
	}

	// Flaky everywhere: https://crbug.com/1024028
	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, DISABLED_ExpiredFlagDoesntApply) {
	set_expiration_enabled(true);
	NavigateToFlagsPage();
	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();
	EXPECT_FALSE(IsFlagPresent(contents, kExpiredFlagName));

	EXPECT_FALSE(base::CommandLine::ForCurrentProcess()->HasSwitch(
	kExpiredFlagSwitchName));
	}
	#endif

	IN_PROC_BROWSER_TEST_P(AboutFlagsBrowserTest, FormRestore) {
	NavigateToFlagsPage();
	content::WebContents* contents =
	browser()->tab_strip_model()->GetActiveWebContents();

	// Remove the internal_name property from a flag's selector, then synthesize a
	// change event for it. This simulates what happens during form restoration in
	// Blink, when navigating back and then forward to the flags page. This test
	// ensures that that does not crash the browser.
	// See https://crbug.com/1038638 for more details.
	EXPECT_TRUE(content::ExecJs(
	contents,
	base::StringPrintf(
	"var k = document.getElementById('%s');"
	"var s = k.getElementsByClassName('experiment-enable-disable')[0];"
	"delete s.internal_name;"
	"const e = document.createEvent('HTMLEvents');"
	"e.initEvent('change', true, true);"
	"s.dispatchEvent(e);",
	kFlagWithOptionSelectorName)));
	}

	} // namespace