tree 75ad25d8e40d0f221783f3fabf15b0211fc1aa5d
parent dc049be66a15e4af43230d8f1d26a0015aac1c58
author Andrew Xu <andrewxu@chromium.org> 1548984234 +0000
committer Ahmed Fakhry <afakhry@chromium.org> 1548984234 +0000

[Merge to M-73] Fix the bug that toggle CapsLock shortcut does not work after using
handwriting input

Handwriting/voice input or emoji generates fake pressing/releasing
key events. But pressing/releasing key events use different key code.
As result, the accelerator history fails to remove the fake pressing
event after receiving the fake releasing event.

In fact, key events with key code of ui::VKEY_PROCESSKEY have no effect
on accelerator processing. So in this CL, stop tracking those key events
in the accelerator history. Meanwhile, refactor the accelerator history
code.

TBR=sky@chromium.org

Test: ash_unittests
Bug: 918317
Change-Id: Iafdc5658c93fc029942dbdc20571558ed84a3eb3
Reviewed-on: https://chromium-review.googlesource.com/c/1427439
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626832}(cherry picked from commit e1c534a395a54afc1ea6aa50a18531a80781b6ab)
Reviewed-on: https://chromium-review.googlesource.com/c/1443715
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#101}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}