commit | 7e0b6498bfe4cf63dc3ac64ef126379cbd5363a5 | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Mon Jul 23 23:44:36 2018 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Mon Jul 23 23:44:36 2018 |
tree | e2fdd8733c0872430c8bc7163b51f816287f5af1 | |
parent | cf2d5c1f1587d0cdd040cfb95f56555141ff53f9 [diff] |
Revert "[Background Fetch] Move all updatable UI options to their own proto." This reverts commit d3981964f2499033059aae600732d656370e0ddf. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577272 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QzOTgxOTY0ZjI0OTkwMzMwNTlhYWU2MDA3MzJkNjU2MzcwZTBkZGYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/71239 Sample Failed Step: site_per_process_content_unittests Original change's description: > [Background Fetch] Move all updatable UI options to their own proto. > > Bundle up the icon and the title since they will be accessed/modified > together in the updateUI call. > > It also makes sense to move the icon from the metadata proto since that > will speed up getting the registration info. > > TBR=avi@chromium.org > > Bug: 865063 > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 > Reviewed-on: https://chromium-review.googlesource.com/1146650 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577272} Change-Id: I3a2cf95f1f058c5c026c68c4ca76998f8ccf52e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865063 Reviewed-on: https://chromium-review.googlesource.com/1147641 Cr-Commit-Position: refs/heads/master@{#577336}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .