Google Git
Sign in
chromium / chromium / src / 7e3f29a34181f6413b5495c023c7593231672095
commit7e3f29a34181f6413b5495c023c7593231672095[log] [tgz]
authorDanyao Wang <danyao@google.com>Fri May 18 16:31:19 2018
committerCommit Bot <commit-bot@chromium.org>Fri May 18 16:31:19 2018
treea15627a766ace66ba9b1df88f0c4a488447cc7dd
parenta7f1ee90249c022de2b5d441bb1e1a3f8c0ecdd7 [diff]
[Nav Experiment] No need to handle cancelled error.

|handleCancelledError| currently reloads the last committed item if
the current provisional navigation is cancelled. This is not needed with
WKBasedNavigation because WKWebView will take care of restoring the last
committed state.

This explicit load is the cause of disappearing forward-history when
user taps on "back" in rapid succession. Each tap starts a new
navigation that is immediately cancelled by the subsequent navigation.
At the end of the chain, when the last committed item is loaded (NTP),
it causes forward history to be lost.

Bug: 841747
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I612a403ac1a7fbe40ea00196aafa2492a3345ce0
Reviewed-on: https://chromium-review.googlesource.com/1065052
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559917}
1 file changed
tree: a15627a766ace66ba9b1df88f0c4a488447cc7dd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .