commit | 7e59f3afd33a3955d54766f7f802d35541e5fb6c | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Feb 20 15:41:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 20 15:41:07 2019 |
tree | 076e15eb8c84a125a94b4a51f819e1908583299d | |
parent | 7567b3b14e64f5fc8f34b61a3049d333ff7f3f81 [diff] |
Remove variable shadowing in blink/modules/cache_storage In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoid is: third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc:313:22: error: declaration shadows a local variable [-Werror,-Wshadow] for (const auto& request_response : responses_) { ^ third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc:277:22: note: previous declaration is here RequestResponse& request_response = Bug: 923510 Change-Id: I8f6b6cd11f80a254c2c926e934dacefaa6dfccf8 Reviewed-on: https://chromium-review.googlesource.com/c/1477285 Reviewed-by: Ben Kelly <wanderview@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#633715}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .