tree 4015c2cd799ccdb2d29b7e03a7bb2b19f053661a
parent 15d707e7b35a8242a4c5306da65b64b356cc40ff
author Marcin Wiącek <marcin@mwiacek.com> 1550879926 +0000
committer Commit Bot <commit-bot@chromium.org> 1550879926 +0000

Migrate Orientation to the @IntDef

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing @Orientation interface in the form common with Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I6e96496eedf82253687c287ea7a70b3c92f63ace
Reviewed-on: https://chromium-review.googlesource.com/c/1480450
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#634876}