Google Git
Sign in
chromium / chromium / src / 80d2d8abff43b8eb2e8b0b36eb6a50ca84b702f9
commit80d2d8abff43b8eb2e8b0b36eb6a50ca84b702f9[log] [tgz]
authorDaniel Bratell <bratell@opera.com>Fri Feb 22 09:37:53 2019
committerCommit Bot <commit-bot@chromium.org>Fri Feb 22 09:37:53 2019
treef508ec23ea71de4f66cbd8bd014e841029e14c27
parent8487fa49052ceddf4dbcc5a03424affd78a6c982 [diff]
[jumbo] Compile fix, one too many BstrToUTF8, rename BstrToPrettyUTF8

https://chromium-review.googlesource.com/c/chromium/src/+/1474976
introduced a BstrToUTF8 which in jumbo builds collided with an
existing (but different) BstrToUTF and broke Windows builds.

This renames one of the conversions to "BstrToPrettyUTF8" since it
not only converts but also makes the string readable for logs.

If the methods had been indentical it would have been suitable
to move them to
content/browser/accessibility/accessibility_tree_formatter_utils_win.cc
I think.

TBR=dmazzoni@chromium.org,iapres@microsoft.com

Bug: 928949
Change-Id: I33660b867e6a4bcabfd274ba976ef642dd65db3a
Reviewed-on: https://chromium-review.googlesource.com/c/1482452
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#634594}
1 file changed
tree: f508ec23ea71de4f66cbd8bd014e841029e14c27
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .