commit | 84a90012847c864b15a9c4bbf0a0dc36a00061b0 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Thu Mar 21 14:34:18 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Mar 21 14:34:18 2019 |
tree | 45d98c06d59842784c4f1fe727d0071c199334ae | |
parent | fb9b8a425bc367a0a4093a5a501027e539ffe8c1 [diff] |
Always use the "C" number locale (fixing blink tests) If you run with a non English, non "C", locale, blink tests would fail since blink uses locale sensitive number to string conversions, and only in C/English locales is the decimal separator ".". For non-test code there was already code that forced the number locale back to "C" but not so for other executables or code path. This sets number locale to "C" in all those places where code set it to something else. Both for renderer processes and other processes. This should not affect the UI since the C lib number conversion routines are not good enough so UI code (should) use icu number to string conversion routines instead. This patch also adds an assert that the locale is correct to catch other/future ways the locale end up incorrectly and deletes some broken test expectations (that hid a symptom of the bug). Android is partly excluded since its locale system works differently and probing the current locale only gives strange data back. Bug: 930701 Change-Id: I15bc0522393d668598d6609dc252aba246ada3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1466443 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#642917}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .