ozone/wayland: dnd: Propagate drag source down to platform drag handler

Ideally, drag source (mouse or touch) should be passed in to platform
drag handler, so that it may be used to determine how to properly
trigger the system drag and drop session, if needed. Under Wayland for
example, is might be used to get the correct serial value as well as to
check internal state before issuing wl_data_device.start_drag request,
which may fail otherwise. Such failures may be tricky to diagnose, as
there is no protocol mechanism to notify them, eg: error events.

This CL address it by modifying WmDragHandler.StartDrag() to include a
drag source parameter and adding the necessary bits to Wayland drag
controller to handle/validate serial and input state before starting the
dnd session.


Bug: 1211874, 1236653
Test: Covered by ozone_unittests.
Change-Id: I85a51b3120009bec88a453657acf0ed465c6ddf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3135837
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/main@{#918013}
12 files changed
tree: d283fbc571142420c2b70858a59560e1cbbd3455
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .mailmap
  9. .vpython
  10. .vpython3
  11. .yapfignore
  13. BUILD.gn
  15. DEPS
  19. LICENSE.chromium_os
  20. OWNERS
  21. PRESUBMIT.py
  22. PRESUBMIT_test.py
  23. PRESUBMIT_test_mocks.py
  24. README.md
  26. android_webview/
  27. apps/
  28. ash/
  29. base/
  30. build/
  31. build_overrides/
  32. buildtools/
  33. cc/
  34. chrome/
  35. chromecast/
  36. chromeos/
  37. cloud_print/
  38. codelabs/
  39. codereview.settings
  40. components/
  41. content/
  42. courgette/
  43. crypto/
  44. dbus/
  45. device/
  46. docs/
  47. extensions/
  48. fuchsia/
  49. gin/
  50. google_apis/
  51. google_update/
  52. gpu/
  53. headless/
  54. infra/
  55. ios/
  56. ipc/
  57. jingle/
  58. media/
  59. mojo/
  60. native_client_sdk/
  61. net/
  62. pdf/
  63. ppapi/
  64. printing/
  65. remoting/
  66. rlz/
  67. sandbox/
  68. services/
  69. skia/
  70. sql/
  71. storage/
  72. styleguide/
  73. testing/
  74. third_party/
  75. tools/
  76. ui/
  77. url/
  78. weblayer/

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.