Google Git
Sign in
chromium / chromium / src / 87f297b2473f64fd56724add74f06392257d1d69
commit87f297b2473f64fd56724add74f06392257d1d69[log] [tgz]
authorQuan Nguyen <qnnguyen@chromium.org>Sat Dec 15 00:31:05 2018
committerCommit Bot <commit-bot@chromium.org>Sat Dec 15 00:31:05 2018
treefeda95efb6e31a98414cf26d44ac4343c6e8b43a
parent0c106ac5879a768a9a37f65e13977682ece96a6c [diff]
cros: fix a crash that occurs after removing a user

Clicking on the "remove user" button the second time would trigger an animation
and then start tearing down the widget tree for the user to be removed (as well
as the user menu bubble). To prevent these two actions from racing, we
immediately hide the user menu widget before starting the teardown. We also
check the widget state early in key/mouse event handlers to prevent crashes
that could happen due to events on an orphaned view that hasn't been deleted
yet.

Bug: 912658
Change-Id: Iccefd785b5a7c8c97829e973bb4f132c406cf58f
Reviewed-on: https://chromium-review.googlesource.com/c/1379219
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616892}
2 files changed
tree: feda95efb6e31a98414cf26d44ac4343c6e8b43a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .