Google Git
Sign in
chromium / chromium / src / 87958ef8be360d5b474ef9718dcfdcc985f32ffb
commit87958ef8be360d5b474ef9718dcfdcc985f32ffb[log] [tgz]
authorRobbie Gibson <rkgibson@google.com>Thu May 23 13:33:29 2019
committerCommit Bot <commit-bot@chromium.org>Thu May 23 13:33:29 2019
treed505adaf6a3eb4aaea62101a737df41542025ff4
parent825acc5c2b7b3921180cd38f2bdc4ed088d12836 [diff]
🦁Fix popup in showcase after introducing layout guides

The layout guides were not set up in showcase, so the popup was broken.

This also fixes a autolayout warning when the second text view was
larger than one line. The stack view didn't know which text view to
shrink if necessary.

This also turns on adjusting content insets due to safe area for the
popup view controller, so the bottom of the popup does respect the
safe area.

Bug: 962957
Change-Id: I626fcb40420f8728094760cb1261766899e82df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611823
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#662603}
5 files changed
tree: d505adaf6a3eb4aaea62101a737df41542025ff4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .