commit | 87fd520daa3e58a52539a82d7a99d68af98491f0 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Apr 03 07:57:33 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Apr 03 07:57:33 2019 |
tree | 719b4a4083451e280c8df6bfc49a0d64062db327 | |
parent | 934200f09ae4133a15e07e77ee8fd06abcc9f99b [diff] |
Adding missing dependencies for dom_distiller_js Generated files did not have their dependencies checked so a missing dependency had gone unnoticed. Now they can be checked with "gn check --check-generated" and then you got these errors (fixed by this patch): ERROR at //out/Default/gen/third_party/dom_distiller_js/dom_distiller_json_converter.h:6:11: Include not allowed. #include "base/values.h" ^------------ It is not in any dependency of //third_party/dom_distiller_js:dom_distiller_proto The include file is in the target(s): //base:base which should somehow be reachable. ___________________ ERROR at //out/Default/gen/third_party/dom_distiller_js/test_sample_json_converter.h:6:11: Include not allowed. #include "base/values.h" ^------------ It is not in any dependency of //third_party/dom_distiller_js:json_values_converter_test_proto The include file is in the target(s): //base:base which should somehow be reachable. Bug: 939782 Change-Id: I8faab4de02ae547c4449c752174e018fe84a6441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547831 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#647183}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .