Google Git
Sign in
chromium / chromium / src / 87ff5db06dc0b51d7dfed48cd620b4bc34cf8da9
commit87ff5db06dc0b51d7dfed48cd620b4bc34cf8da9[log] [tgz]
authorRenato Silva <rrsilva@google.com>Thu Oct 31 18:17:26 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 31 18:17:26 2024
treeba72085baa8c004cdaf3be7378154cd7ba66b54e
parentcd2cc066333004182084ba465ef7814c490178e9 [diff]
[High5][OOBE] Simplify PinSetupMode logic

PinSetupMode controls which mode the PinSetupScreen operates on. This
change introduces some methods in WizardController that can be used
for showing the screen and setting the appropriate mode at the same
time, isolating this implementation detail. It makes the default
PinSetupMode to be 'SecondaryFactor', which is how this screen has
been used throughout ChromeOS and removes excessive checks in the
logic. The decision to not show the PinSetupScreen when the user has
already set a PIN is now being done directly in WizardController, when
the fingerprint screen finishes. This also fixes an issue where a CHECK
was going off when resuming the user onboarding process.

Bug: b/348326316, b/365059362
Fixed: b/376234823
Change-Id: I11c902db723cab114fedeeab4ad18c2606479158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979769
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376466}
6 files changed
tree: ba72085baa8c004cdaf3be7378154cd7ba66b54e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.