Make table columns stop using `LayoutBox::SetLogical{Width,Height}`

Table columns and column groups don't need to be laid out, but they
have associated `LayoutBox` objects, and they have a size that can be
queried with `col.offset{Height,Width}`. This is achieved without
laying them out by calling `LayoutBox::SetLogical{Width,Height}`.
These methods, however, are being removed as part of the NoCopyBack

This change instead makes `LayoutNGTableColumn` override
`LayoutBox::Size` to provide a size that can be set through methods
defined in `LayoutNGTableColumn`, independent of `LayoutBox`. The
change also makes `col.offset{Top,Left}` work (by overriding
`LayoutBox::Location`) and makes sure that "out of bounds" columns and
colgroups (that is, columns and colgroup boxes which don't correspond
to any actual column in the table) have offset values that make sense.

Bug: 1371882
Change-Id: I3dae24122479730af1841f09405a4d33694f1972
Commit-Queue: Andreu Botella <>
Reviewed-by: Kent Tamura <>
Cr-Commit-Position: refs/heads/main@{#1120302}
6 files changed
tree: 7b2c3e44c30e281e10c558bdd96bb436cac39c88
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  66. codereview.settings
  67. DEPS
  70. LICENSE.chromium_os
  71. OWNERS

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at