commit | 8a2fbf15435187a630884ca09b09b6c121ef57fb | [log] [tgz] |
---|---|---|
author | Andreu Botella <abotella@igalia.com> | Wed Mar 22 00:30:24 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 22 00:30:24 2023 |
tree | 7b2c3e44c30e281e10c558bdd96bb436cac39c88 | |
parent | c47118ee45664adb9bf68c1f145b6313e7521750 [diff] |
Make table columns stop using `LayoutBox::SetLogical{Width,Height}` Table columns and column groups don't need to be laid out, but they have associated `LayoutBox` objects, and they have a size that can be queried with `col.offset{Height,Width}`. This is achieved without laying them out by calling `LayoutBox::SetLogical{Width,Height}`. These methods, however, are being removed as part of the NoCopyBack project. This change instead makes `LayoutNGTableColumn` override `LayoutBox::Size` to provide a size that can be set through methods defined in `LayoutNGTableColumn`, independent of `LayoutBox`. The change also makes `col.offset{Top,Left}` work (by overriding `LayoutBox::Location`) and makes sure that "out of bounds" columns and colgroups (that is, columns and colgroup boxes which don't correspond to any actual column in the table) have offset values that make sense. Bug: 1371882 Change-Id: I3dae24122479730af1841f09405a4d33694f1972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4290876 Commit-Queue: Andreu Botella <abotella@igalia.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1120302}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.