tree 47d557a47edb85094d87951dc3ecab5cb86ec256
parent a8ab152bea548cbc0cc423b3449b4987317a3c78
author Fergal Daly <fergal@chromium.org> 1642558741 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1642558741 +0000

Check the return value of AddTabAtIndex(ToBrowser) in tests.

Final goal is to mark WaitForLoadStop as WARN_IF_UNUSED.

This adds ASSERT_TRUE/FALSE to all calls such that tests continue to
pass (except in non-void functions which must use EXPECT instead).

This CL is a split of https://crrev.com/c/2852829.
It covers /chrome/browser/ui/views

I'm splitting into many to avoid one rollback undoing the whole thing
as some of these may turn out to be flaky.

There are 37 CLs covering 161 call-sites in total, I cannot
investigate why individual cases are unexpectedly TRUE/FALSE. Unless
you think it indicates a bug in the test infrastructure, please
approve and investigate the unexpected cases of your directory in
follow-on bugs/CLs.

This CL was uploaded by git cl split.

R=collinbaker@chromium.org

Bug: 1014186,425335
Change-Id: I476be86c8b06f8e2b1043d938eb9650864b64401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3394395
Auto-Submit: Fergal Daly <fergal@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/main@{#960758}