Google Git
Sign in
chromium / chromium / src / 8da519aa4f354a196dbe23c1a936d75f12089ea5
commit8da519aa4f354a196dbe23c1a936d75f12089ea5[log] [tgz]
authorAntonio Gomes <tonikitoo@igalia.com>Tue Dec 08 15:13:19 2020
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Dec 08 15:13:19 2020
treee72115221a0d9c930de95c747257627a231ee188
parentf14d460878aeb01c1e3b62bb0a121c1331c1fb67 [diff]
Implement ImmersiveContextLacros::OnEnteringOrExitingImmersive()

Problem: In HTML fullscreen (eg YouTube video) the shelf slides
up when the cursor is at the screen bottom.

This CL fixes the problem by changing Lacros to use
`ZAURA_SURFACE_FULLSCREEN_MODE_PLAIN` by default, which fixes the
HTML fullscreen case, ie no shelf interaction.

Then, by implementing the existing hook
ImmersiveContextLacros::OnEnteringOrExitingImmersive(bool), this CL
allows Lacros to react when the `immersive fullscreen` status changes,
toggling ZAURA_SURFACE_FULLSCREEN_MODE_IMMERSIVE on and off on Ozone,
accordingly. It enables interaction with ChromeOS' shelf widget
when in immersive fullscreen is ON.

BUG=1145388
R=jamescook@chromium.org, nickdiego@igalia.com, rjkroege@chromiun.org

Change-Id: Ifbb6529ea9dd722a85e9c37723900ee899d5f358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575001
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834710}
4 files changed
tree: e72115221a0d9c930de95c747257627a231ee188
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. DIR_METADATA
  16. ENG_REVIEW_OWNERS
  17. LICENSE
  18. LICENSE.chromium_os
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. PRESUBMIT_test_mocks.py
  23. README.md
  24. WATCHLISTS
  25. android_webview/
  26. apps/
  27. ash/
  28. base/
  29. build/
  30. build_overrides/
  31. buildtools/
  32. cc/
  33. chrome/
  34. chromecast/
  35. chromeos/
  36. cloud_print/
  37. codelabs/
  38. codereview.settings
  39. components/
  40. content/
  41. courgette/
  42. crypto/
  43. dbus/
  44. device/
  45. docs/
  46. extensions/
  47. fuchsia/
  48. gin/
  49. google_apis/
  50. google_update/
  51. gpu/
  52. headless/
  53. infra/
  54. ios/
  55. ipc/
  56. jingle/
  57. media/
  58. mojo/
  59. native_client_sdk/
  60. net/
  61. pdf/
  62. ppapi/
  63. printing/
  64. remoting/
  65. rlz/
  66. sandbox/
  67. services/
  68. skia/
  69. sql/
  70. storage/
  71. styleguide/
  72. testing/
  73. third_party/
  74. tools/
  75. ui/
  76. url/
  77. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.