Google Git
Sign in
chromium / chromium / src / 8f7008ef0afa21b3eb931190f7583d05a2852a8f
commit8f7008ef0afa21b3eb931190f7583d05a2852a8f[log] [tgz]
authorMiyoung Shin <myid.shin@igalia.com>Mon Jan 18 17:33:57 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 18 17:33:57 2021
tree60ce2b9c1e8d41e879d905f7afca25ecdb4ec46a
parente3cba902897c9e65f162d98fa3c2a2d3d43fff9d [diff]
Fix WebViewClient#onPageCommitVisible callback not invoke

This CL keep a swap promise as active when DidNotSwap is called
with the commit fail to fix the problem that
WebViewClient#onPageCommitVisible callback is not invoked or
callbacks arrive at once.

This problem was introduced since the CL[1] converted
FrameMsg_VisualStateRequest to mojo because the CL missed the
migration from the original code[2] which was being ported.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2342532
[2] https://chromium.googlesource.com/chromium/src/+/c75c53f04b0207e654fd2f7f05e6b785988ea30e/content/renderer/frame_swap_message_queue.cc#124

Bug: 1148808
Change-Id: I935bee95332e775fd13fea15fedc856d34b37649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636094
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#844566}
1 file changed
tree: 60ce2b9c1e8d41e879d905f7afca25ecdb4ec46a
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. DIR_METADATA
  16. ENG_REVIEW_OWNERS
  17. LICENSE
  18. LICENSE.chromium_os
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. PRESUBMIT_test_mocks.py
  23. README.md
  24. WATCHLISTS
  25. android_webview/
  26. apps/
  27. ash/
  28. base/
  29. build/
  30. build_overrides/
  31. buildtools/
  32. cc/
  33. chrome/
  34. chromecast/
  35. chromeos/
  36. cloud_print/
  37. codelabs/
  38. codereview.settings
  39. components/
  40. content/
  41. courgette/
  42. crypto/
  43. dbus/
  44. device/
  45. docs/
  46. extensions/
  47. fuchsia/
  48. gin/
  49. google_apis/
  50. google_update/
  51. gpu/
  52. headless/
  53. infra/
  54. ios/
  55. ipc/
  56. jingle/
  57. media/
  58. mojo/
  59. native_client_sdk/
  60. net/
  61. pdf/
  62. ppapi/
  63. printing/
  64. remoting/
  65. rlz/
  66. sandbox/
  67. services/
  68. skia/
  69. sql/
  70. storage/
  71. styleguide/
  72. testing/
  73. third_party/
  74. tools/
  75. ui/
  76. url/
  77. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.