commit | 8fd5d9a5f649b5914acc3dca5eda3d821199a7a8 | [log] [tgz] |
---|---|---|
author | Stephen McGruer <smcgruer@chromium.org> | Tue Mar 19 15:30:58 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 19 15:30:58 2019 |
tree | 28a42f8604ede0167450928de478ab0dd7eb9d94 | |
parent | 1fcfd3fed3a585ae8558f39f75389667766cb54f [diff] |
Correctly specify CSS Transition timing functions on the effect Previously they were specified on the start_keyframe because we didn't want the delay keyframe to be affected by the timing function. Now that the delay keyframe has been removed (https://crrev.com/fde1ecb), the timing function can be left on the effect. Fixing this also requires changing the time calculation in the 'transitioncancel' event firer code. Previously this was calculated from the transformed-progress[0] multiplied by the iteration duration[1]. However the transformed-progress includes the timing function, and the spec actually says to use[2]: "The active time of the animation at the moment it was cancelled calculated using a fill mode of both." Finally, this change fixes re-targeting of in-flight transitions, which previously only worked properly for linear transitions. [0]: https://drafts.csswg.org/web-animations-1/#calculating-the-transformed-progress [1]: https://drafts.csswg.org/web-animations-1/#iteration-duration [2]: https://drafts.csswg.org/css-transitions-2/#event-dispatch Bug: 934709 Change-Id: I73545795e1aa5b009461fea6f610c145262058c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526481 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641917}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .