commit | 90c86f0ce73498a900dbb601f1de95dc519de18a | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Fri Feb 22 14:51:23 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 22 14:51:23 2019 |
tree | 48cfe4b9dbca5ccf58cad5db35fbd4614b7ac86c | |
parent | 1ee5a0810dd9d4362e94e91d155548ac53daeb04 [diff] |
Revert "Take scheme in CookieStore::SetCanonicalCookieAsync, not just whether it's secure." This reverts commit 5760a6f2d7a24ee7e2cfac2c399f8756db91be83. Reason for revert: Clashed with some other change so all Android builders died with: [1078/8826] CXX obj/android_webview/common/aw_cookie_manager_wrapper.o FAILED: obj/android_webview/common/aw_cookie_manager_wrapper.o ../../android_webview/browser/net_network_service/aw_cookie_manager_wrapper.cc -o obj/android_webview/common/aw_cookie_manager_wrapper.o ../../android_webview/browser/net_network_service/aw_cookie_manager_wrapper.cc:40:43: error: reference to type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') could not bind to an lvalue of type 'bool' cookie_manager_->SetCanonicalCookie(cc, secure_source, modify_http_only, ^~~~~~~~~~~~~ gen/services/network/public/mojom/cookie_manager.mojom.h:179:82: note: passing argument to parameter 'source_scheme' here void SetCanonicalCookie(const net::CanonicalCookie& cookie, const std::string& source_scheme, bool modify_http_only, SetCanonicalCookieCallback callback) final; ^ 1 error generated. Original change's description: > Take scheme in CookieStore::SetCanonicalCookieAsync, not just whether it's secure. > > This permits to check it against list of cookieable schemes (fixing #850044), and is > a prerequisite for getting rid of SetCookieWithOptionsAsync in favor of everything > using SetCanonicalCookieAsync. > > Bug: 850044 > Change-Id: I890cf266767a124b116fc553932a74b5a97ed943 > Reviewed-on: https://chromium-review.googlesource.com/c/1450420 > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634646} TBR=jam@chromium.org,caseq@chromium.org,tsepez@chromium.org,eugenebut@chromium.org,pwnall@chromium.org,mkwst@chromium.org,morlovich@chromium.org Change-Id: I17b82ee596c4cdcebfc8774f06b7e155ead8c514 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850044 Reviewed-on: https://chromium-review.googlesource.com/c/1482460 Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#634658}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .