Google Git
Sign in
chromium / chromium / src / 930ea94617e6255f1b358a9a27f8da4a9471f98b
commit930ea94617e6255f1b358a9a27f8da4a9471f98b[log] [tgz]
authormark a. foltz <mfoltz@chromium.org>Mon Feb 11 23:04:01 2019
committerCommit Bot <commit-bot@chromium.org>Mon Feb 11 23:04:01 2019
tree2cd6a9e4a666f26e8e65eceb3d4bf0ec6be9885b
parente377eb6cdcdab37607ae25361e06721afcaf1003 [diff]
[Presentation API] Reject PresentationRequest.start() with the correct error.

This fixes the PresentationService so that start will reject with an
OperationError if there is a pending start Promise from the same frame.
This matches step 3 of the Presentation API spec [1].

Tested manually with the corresponding WPT [2].

[1] https://w3c.github.io/presentation-api/#selecting-a-presentation-display
[2] https://github.com/web-platform-tests/wpt/blob/master/presentation-api/controlling-ua/startNewPresentation_unsettledpromise-manual.https.html

Bug: 647504
Change-Id: If3f50e70321136556ed1a3d3ab1f4b763a6aa9eb
Reviewed-on: https://chromium-review.googlesource.com/c/1460101
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630975}
1 file changed
tree: 2cd6a9e4a666f26e8e65eceb3d4bf0ec6be9885b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .