tree 187acb8d59ba6b84866ac9a941f96d10de7cf082
parent f298ce16a649f566d879b120d365d1e9edd6a978
author Reilly Grant <reillyg@chromium.org> 1712080616 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1712080616 +0000

Revert "[Reland 2] lens overlay: Fix context menu entry point."

This reverts commit 8b6553f30f9f7d9ecb670e533a563a23a43c644a.

Reason for revert: Consistent failures on https://ci.chromium.org/ui/p/chromium/builders/ci/win-asan/30489/overview.

Original change's description:
> [Reland 2] lens overlay: Fix context menu entry point.
>
> The first 2 attempts to land this CL resulted in test flakiness. The
> test flakiness was caused by the renderer dropping input events before
> first paint. This CL adds a wait for first paint. This wait should
> eventually be replaced by a fix to the interactve test harness itself.
>
> > The original CL modifies a kombucha test. The modified test fails in
> > ubsan builds. This appears to be a race condition in kombucha itself, as
> > kombucha steps run nested by default. This reland takes all the kombucha
> > steps and flushes events after every step to avoid this
> > non-deterministic and racy behavior.
> >
> > > This CL allows us to correctly hook up the CUJ test. This CL prevents
> > > lens overlay from triggering for non-normal windows.
> >
> > Bug: 331114227
> > Change-Id: Ia2043b6df13b3b2eb8353739cae48d12f0ec4a81
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5400496
> > Reviewed-by: David Pennington <dpenning@chromium.org>
> > Commit-Queue: Erik Chen <erikchen@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1279061}
>
> Change-Id: I2ca2a6976cb45fbab2e3f182cdab549119cf17e7
> Bug: 331114227, 331859922
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5409680
> Reviewed-by: David Pennington <dpenning@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1280903}

Bug: 331114227, 331859922, 331783107
Change-Id: Id24fd37da05518d5d874f0726c62f26373414835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5414197
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Owners-Override: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1281302}