commit 94a82ccf8ead4f644f97b39f822ba6d3914e1968
author Christian Biesinger <cbiesinger@chromium.org> Thu Mar 14 20:20:16 2019
committer Commit Bot <commit-bot@chromium.org> Thu Mar 14 20:20:16 2019
tree 98d336cbbbd67b49455c7e8ee0f11744d70a1242
parent 8ddaa62025cb1934a3ff6bb924d2c4790e90d149

[layoutng] Inline the ShapeResultSpacing constructor

Good performance data:
https://pinpoint-dot-chromeperf.appspot.com/job/11a140e8f40000

Change-Id: I171ca316fbd8336576dbc78929bf48d35b1494e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1330077
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640900}

third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.cc

diff --git a/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.cc b/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.cc
index 8e6a111d..128481c 100644
--- a/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.cc
+++ b/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.cc
@@ -10,21 +10,6 @@
 namespace blink {
 
 template <typename TextContainerType>
-ShapeResultSpacing<TextContainerType>::ShapeResultSpacing(
-    const TextContainerType& text)
-    : text_(text),
-      letter_spacing_(0),
-      word_spacing_(0),
-      expansion_(0),
-      expansion_per_opportunity_(0),
-      expansion_opportunity_count_(0),
-      text_justify_(TextJustify::kAuto),
-      has_spacing_(false),
-      normalize_space_(false),
-      allow_tabs_(false),
-      is_after_expansion_(false) {}
-
-template <typename TextContainerType>
 bool ShapeResultSpacing<TextContainerType>::SetSpacing(
     const FontDescription& font_description) {
   if (!font_description.LetterSpacing() && !font_description.WordSpacing()) {

third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.h

diff --git a/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.h b/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.h
index 391de422..42a3061 100644
--- a/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.h
+++ b/third_party/blink/renderer/platform/fonts/shaping/shape_result_spacing.h
@@ -20,7 +20,18 @@
   STACK_ALLOCATED();
 
  public:
-  explicit ShapeResultSpacing(const TextContainerType&);
+  explicit ShapeResultSpacing(const TextContainerType& text)
+      : text_(text),
+        letter_spacing_(0),
+        word_spacing_(0),
+        expansion_(0),
+        expansion_per_opportunity_(0),
+        expansion_opportunity_count_(0),
+        text_justify_(TextJustify::kAuto),
+        has_spacing_(false),
+        normalize_space_(false),
+        allow_tabs_(false),
+        is_after_expansion_(false) {}
 
   const TextContainerType& Text() const { return text_; }
   float LetterSpacing() const { return letter_spacing_; }